Add CakePHP 6.0 rector rules for void return type changes#384
Draft
dereuromark wants to merge 3 commits into5.xfrom
Draft
Add CakePHP 6.0 rector rules for void return type changes#384dereuromark wants to merge 3 commits into5.xfrom
dereuromark wants to merge 3 commits into5.xfrom
Conversation
Add rector rules for upgrading to CakePHP 6.0: - RemoveAssignmentFromVoidMethodRector: Removes variable assignments from method calls that now return void instead of bool - Method renames: validChoice() -> validateChoice() for ConsoleInput classes Affected methods: - ServerRequest::allowMethod() - Configure::load() - ResponseEmitter::emit() - Session::close() - Table::deleteOrFail() - FixtureInterface::insert() - FixtureInterface::truncate() - ConsoleInputArgument::validChoice() -> validateChoice() - ConsoleInputOption::validChoice() -> validateChoice() Refs cakephp/cakephp#19220 Refs cakephp/cakephp#19243
Contributor
|
why is this on 5.x? there is a 6.x branch already present with the basic setup for 6.x and a refactored folder structure. |
Member
Author
|
Wrong branch jep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add rector rules for upgrading to CakePHP 6.0, specifically handling methods that changed from returning
boolto returningvoid.New Rules:
RemoveAssignmentFromVoidMethodRector - Removes variable assignments from method calls that now return void:
Method Renames - Renames
validChoice()tovalidateChoice()for console input classesAffected Methods:
ServerRequestallowMethod()voidConfigureload()voidResponseEmitteremit()voidSessionclose()voidTabledeleteOrFail()voidFixtureInterfaceinsert()voidFixtureInterfacetruncate()voidConsoleInputArgumentvalidChoice()validateChoice(), returnsvoidConsoleInputOptionvalidChoice()validateChoice(), returnsvoidRelated PRs: